Extract FanArtTV telemetry contracts - #5
Merged
Conversation
Move the stable activity source and meter names into a lightweight diagnostics package so OpenTelemetry registration no longer depends on the full client graph. Preserve the existing public type through forwarding and publish all three packages together. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
cjaliaga
added a commit
that referenced
this pull request
Aug 7, 2026
* Extract FanArtTV telemetry contracts (#5) Move the stable activity source and meter names into a lightweight diagnostics package so OpenTelemetry registration no longer depends on the full client graph. Preserve the existing public type through forwarding and publish all three packages together. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Complete telemetry split forward port Preserve main's manual release fallback while carrying the Diagnostics package through all build and publish workflows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 303993ae-a512-46f4-bbb6-8f66a6838305 --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 303993ae-a512-46f4-bbb6-8f66a6838305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TrackSeries.FanArtTV.Client.Diagnosticscontract packageValidation
net8.0andnet10.02.0.4TrackSeries.FanArtTV.Client.Diagnostics 2.0.4andOpenTelemetry.Extensions.Hosting 1.17.0; no main client dependencyTrackSeries.FanArtTV.ClientabsentRelease
This targets the
v2.0maintenance branch so NBGV assigns the next stable version,2.0.4.Use squash merge or rebase merge. Do not create a merge commit: an explicit NBGV simulation showed that a merge commit would add a second version-height commit and produce
2.0.5; squash/rebase keeps the release at2.0.4.After review and squash/rebase merge, verify
dotnet nbgv get-version -v NuGetPackageVersionreturns2.0.4, then create and push the annotatedv2.0.4tag on that commit to trigger the established NuGet publishing workflow.